Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(microservices): add commit offsets doc for kafka #2230

Merged
merged 6 commits into from
Feb 6, 2023

Conversation

davidschuette
Copy link
Contributor

This is the associated documentation for PR #9270 of nest.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Issue Number: PR #9270 of nestjs/nest

What is the new behavior?

Add documentation for usage of commitOffsets for ClientKafka.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is the associated documentation for PR #9270 of nest.
content/microservices/kafka.md Outdated Show resolved Hide resolved
content/microservices/kafka.md Outdated Show resolved Hide resolved
@davidschuette
Copy link
Contributor Author

@johannesschobel Thank you for the review. I will update the PR with your suggestions and with some more content when this PR gets merged.

Co-authored-by: Johannes Schobel <johannesschobel@users.noreply.github.com>
@kamilmysliwiec kamilmysliwiec merged commit 096f33b into nestjs:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants