Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: drop update command from cli page #2373

Merged
merged 1 commit into from Jun 28, 2022
Merged

docs: drop update command from cli page #2373

merged 1 commit into from Jun 28, 2022

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Issue Number: in favor of nestjs/nest-cli#1699

What is the new behavior?

No docs on update command

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Tony133 Tony133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a little warning on what to use to update dependencies? it could be useful to people right?

@micalevisk
Copy link
Member Author

@Tony133 we could mention that in the migration guide, I guess?

@Tony133
Copy link
Contributor

Tony133 commented Jun 27, 2022

It would be a good idea or even on this page where there are all the commands. To you the choice 👍

@jmcdo29 what do you think?

@kamilmysliwiec kamilmysliwiec merged commit c7ee64e into nestjs:9.0.0 Jun 28, 2022
@micalevisk micalevisk deleted the patch-1 branch June 28, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants