Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(migration): Adding a section for upgrading packages #2764

Merged
merged 3 commits into from Jun 20, 2023

Conversation

tsteuwer
Copy link
Contributor

@tsteuwer tsteuwer commented Jun 18, 2023

Adding a note that NestJS doesn't include an update command and to use npm-check-updates per Member recommendation.

The reason why I'd like to add this is I was recently looking to upgrading from V9 to V10 and figured the CLI included an update command but it was removed. Looking into this more it was recommended by @kamilmysliwiec to use npm-check-updates. I figured others would benefit from this like I did by adding it to the Migration guide.

If no one thinks this is useful like I did, we can close this.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

There is no current update command and it's recommended to use ncu.

What is the new behavior?

A note that Nest CLI does not include an update command (yet) and to manually upgrade packages or use ncu.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N/A

Adding a new section to the Migration guide letting users know there is no `update` command and to use ncu per Member recommendation.
@Tony133
Copy link
Contributor

Tony133 commented Jun 18, 2023

Actually the "update" command was included in the CLI of Nest up to version 8 of NestJS but it was removed because it didn't update dependencies correctly and had stability problems, see screenshot
cli-command

if we really want to add a warning or a notice, I would say add it in the CLI section: https://docs.nestjs.com/cli/overview

@tsteuwer
Copy link
Contributor Author

That's fine with me as long as everyone's in agreement with that @Tony133 . Who do we need to confirm with on if it should be in migration or over on the CLI page?

content/migration.md Outdated Show resolved Hide resolved
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 74ec5a0 into nestjs:master Jun 20, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants