Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): update advertising banner css style #2922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Dec 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Issue Number:

What is the new behavior?

Proposal:

  • Update advertising banner css style

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Before:

screen-before-advertising-banner

After ( with fix ):

screen-fix-ok screen-fix

@Tony133 Tony133 changed the title fix: update advertising banner css style fix(): update advertising banner css style Dec 15, 2023
@Tony133
Copy link
Contributor Author

Tony133 commented Dec 15, 2023

Link for preview: https://deploy-preview-2922--docs-nestjs.netlify.app/techniques/database 🔥

@Tony133 Tony133 mentioned this pull request Jan 19, 2024
Copy link

@smith558 smith558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a fix. Looking at the preview, this proposed change hides the ads until the user scrolls all the way to the bottom, making them essentially unreachable (which is obviously undesirable).

@Tony133
Copy link
Contributor Author

Tony133 commented Feb 28, 2024

@smith558 other solutions are always accepted, if you have another solution please post it here.

@smith558
Copy link

@smith558 other solutions are always accepted, if you have another solution please post it here.

Unfortunately I do not have time currently. But I am just saying. This proposed way of fix would lead to very much decreased income from the Carbon ads placed on the website because they track "impressions".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants