Update prisma.md #2989
Open
Update prisma.md #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What? This pull request modifies the post creation process to utilize authorId instead of authorEmail for associating posts with their authors. Why? The initial implementation encountered errors when using authorEmail due to its inability to directly associate with the User entity. By switching to authorId, we ensure a direct and efficient connection between posts and users, resolving the error and maintaining data integrity. How? Updated post creation logic to reference authorId for associating posts with authors. Removed usage of authorEmail in post creation to prevent errors and improve data consistency. Testing? Conducted thorough testing to verify correct operation of post creation with both existing and new users. Ensured that the updated logic does not introduce regressions and maintains expected behavior.
sumitj18s
reviewed
Apr 4, 2024
| async createDraft( | ||
| @Body() postData: { title: string; content?: string; authorEmail: string }, | ||
| @Body() postData: { title: string; content?: string; authorId: number }, |
There was a problem hiding this comment.
Suggested change
| @Body() postData: { title: string; content?: string; authorId: number }, | |
| @Body() postData: { authorId: number; title: string; content?: string }, |
| ): Promise<PostModel> { | ||
| const { title, content, authorEmail } = postData; | ||
| const { title, content, authorId } = postData; |
There was a problem hiding this comment.
Suggested change
| const { title, content, authorId } = postData; | |
| const { authorId, title, content } = postData; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
changing the post creation unstead of authorEmail i fix it to use authorId
Does this PR introduce a breaking change?
No
Other information