Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add tslib dependency to the @nestjs/apollo package #2079

Merged
merged 2 commits into from Mar 14, 2022
Merged

build: add tslib dependency to the @nestjs/apollo package #2079

merged 2 commits into from Mar 14, 2022

Conversation

JaLe29
Copy link
Contributor

@JaLe29 JaLe29 commented Mar 12, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Workspace @nestjs/apollo is missing dependency tslib.

Yarn berry (because berry is checking dependency tree) is throwing following error:

Error: @nestjs/apollo tried to access tslib, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: tslib

What is the new behavior?

tslib is added into @nestjs/apollo package.json file.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@JaLe29
Copy link
Contributor Author

JaLe29 commented Mar 12, 2022

looks like tslib is not used by apollo, there must be some other issue

@JaLe29 JaLe29 closed this Mar 12, 2022
@JaLe29 JaLe29 reopened this Mar 12, 2022
@JaLe29
Copy link
Contributor Author

JaLe29 commented Mar 12, 2022

packages/apollo/dist/index.js is really using tslib.

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const tslib_1 = require("tslib");
tslib_1.__exportStar(require("./decorators"), exports);
tslib_1.__exportStar(require("./drivers"), exports);
tslib_1.__exportStar(require("./interfaces"), exports);
tslib_1.__exportStar(require("./utils"), exports);

@kamilmysliwiec kamilmysliwiec changed the title build: @nestjs/apollo tslib build: add tslib dependency to the @nestjs/apollo package Mar 14, 2022
@kamilmysliwiec kamilmysliwiec merged commit 8540b07 into nestjs:master Mar 14, 2022
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants