perf(@nestjs/graphql): make it faster to construct a typescript file from GraphQL schema #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katainaka0503
changed the title
katainaka0503
force-pushed
the
improve-compilation-time
branch
from
6c26b29
to
476b2b6
Compare
Use structure for ts file construction
katainaka0503
force-pushed
the
improve-compilation-time
branch
from
476b2b6
to
590aa9b
Compare
katainaka0503
changed the title
katainaka0503
changed the title
katainaka0503
changed the title
Construct all the contents of the generated typescript file by structure
katainaka0503
commented
Mar 21, 2022
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| /* tslint:disable */ | |||
| /* eslint-disable */ | |||
|
|
|||
There was a problem hiding this comment.
This PR slightly changes output file about blank lines
|
@kamilmysliwiec Hi! Is there anything I can help you review this PR? |
|
lgtm |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ts-morph's structure for typescript file construction.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
ts-morph'sStructureto construct ts file, which improves time to construct a typescript file from schema. This makes it faster to construct a typescript file from GraphQL schema from 40s to ~3s in my environment.What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Both are in my environment.
before
after