Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Yoga driver #2145

Closed

Conversation

charlypoly
Copy link
Contributor

@charlypoly charlypoly commented Apr 20, 2022

This PR add supports for GraphQL Yoga which brings:

  • Express support
  • Fastify support
  • embedded GraphiQL
  • File uploads support
  • CORS default
  • Error masking
  • subscriptions support
  • lightweight bundle 馃摝 馃

https://www.graphql-yoga.com/

@kamilmysliwiec
Copy link
Member

@charlypoly thank you for this contribution, this is amazing!

However, the reason we extracted drivers out of the "core" package is that we wanted to expose a mechanism that would let other community members integrate custom drivers that we can't maintain & keep under the official organization (mainly due to the limited team bandwidth & time). Bringing another driver in would decrease our velocity even further (and given the amount of packages & drivers we already maintain, it's getting more and more difficult).

So in this case, I'd rather suggest creating a new repository & new package and publishing it as a separate community-driven OSS package. Once it's published, definitely let me know and I'll make sure we mention it (add a dedicated section in README/maybe docs too?) and link it here :)

@charlypoly
Copy link
Contributor Author

@kamilmysliwiec thank you for your feedback, we will proceed as you stated.
In the meantime, could you review and publish this change proposal that is required for us to integrate with @nestjs/graphql: #2156

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants