Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apollo): Update resolveReference location #2245

Merged

Conversation

trevor-scheer
Copy link
Contributor

The location of resolveReference was updated in the @apollo/subgraph library to live on a type's extensions object rather than directly on the object itself. The extensions are treated as public API w.r.t. graphql-js.

Reference:
apollographql/federation#1746
apollographql/federation#1747

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue Number: #2228

Does this PR introduce a breaking change?

  • Yes
  • No

The location of `resolveReference` was updated in the
`@apollo/subgraph` library to live on a type's `extensions` object.

Reference:
apollographql/federation#1746
apollographql/federation#1747
@trevor-scheer trevor-scheer changed the title fix(apollo): Update resolveReference location fix(apollo): Update resolveReference location Jun 14, 2022
@trevor-scheer
Copy link
Contributor Author

If there were tests in place for this previously, they would have failed when updating devDependencies.@apollo/subgraph to 0.4.2 in #2155. Would someone mind helping me add tests for this? This would let me confirm backcompat and that this change does indeed fix the issue that was originally introduced.

@kamilmysliwiec kamilmysliwiec merged commit 56b764e into nestjs:master Jun 15, 2022
@kamilmysliwiec
Copy link
Member

LGTM

@trevor-scheer
Copy link
Contributor Author

@kamilmysliwiec I still think this needs tests...

@trevor-scheer trevor-scheer deleted the trevor/subgraph-resolve-reference branch June 22, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants