fix(schema-first): merge duplicate IQuery interface #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| @@ -35,9 +36,17 @@ export class GraphQLFederationDefinitionsFactory extends GraphQLDefinitionsFacto | |||
| resolvers: {}, | |||
| }, | |||
| ]); | |||
|
|
|||
| const mergedDefinition = mergeTypeDefs([printSubgraphSchema(schema)], { | |||
There was a problem hiding this comment.
Should we add a comment explaining why this is needed? (with a link to the original issue)
There was a problem hiding this comment.
I agree that such a comment should be here. I'll add it.
packages/graphql/lib/federation/graphql-federation-definitions.factory.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2344
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2344
As described in the issue,
GraphQLFederationDefinitionsFactoryemits duplicate IQuery interface.This is caused by
buildSubgraphSchema, which fills empty Query definition when there is no originaltype Querydefinition and there isextend type Querydefinition.What is the new behavior?
Duplicate IQuery interface will be merged.
Does this PR introduce a breaking change?
Other information