feat(graphql): Throw an error when multiple resolvers define the same field #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/graphql/lib/interfaces/build-schema-options.interface.ts
Outdated
Show resolved
Hide resolved
packages/graphql/lib/schema-builder/errors/multiple-fields-with-same-name.error.ts
Outdated
Show resolved
Hide resolved
|
Fantastic PR, thank you! Left a few very minor comments |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Closes #2143
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2134
What is the new behavior?
A new
buildSchemaOptionsfieldnoDuplicateFieldsis added.If it is set to
true, an error is thrown when defining a Query/Mutation field multiple timesDoes this PR introduce a breaking change?