fix(graphql): prevent potential memory leak for mostly falsy filter function #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcdo29
reviewed
Feb 4, 2023
packages/apollo/package.json
Outdated
Comment on lines
18
to
20
| "test:e2e": "node --expose-gc ../../node_modules/.bin/jest --config ./tests/jest-e2e.ts --runInBand && yarn test:e2e:fed2", | ||
| "test:e2e:fed2": "node --expose-gc ../../node_modules/.bin/jest --config ./tests/jest-e2e-fed2.ts --runInBand", | ||
| "test:e2e:dev": "node --expose-gc ../../node_modules/.bin/jest --config ./tests/jest-e2e.ts --runInBand --watch" |
There was a problem hiding this comment.
Appreciate you wanting to show that there's not a memory leak, but is it really necessary to change the commands themselves rather than possibly updating the CI to watch for this?
There was a problem hiding this comment.
I found a solution to use global.gc() without node flags. Check out the new PR.
niceandneat
force-pushed
the
fix-memory-leak-async-iterator
branch
from
aea0458
to
cd29258
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
As apollographql/graphql-subscriptions#209 saids, a filter function that returns mostly false can cause loops in Promises. This leads to a memory leak.
Issue Number: N/A
Relevant Issue: apollographql/graphql-subscriptions#212
What is the new behavior?
Applied changes of above PR to existing function
createAsyncIterator.Now it does not stack up awaiting Promises.
Credit to. @urossmolnik
Does this PR introduce a breaking change?
Other information