fix: metadata storage refactor caused a bug in field resolver #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a field resolver with an input we reached a bad edge case where the fields array was fetched via reference instead of an immutable array. This caused artifacts appearing in the array and bad metadata appeared when trying to parse the schema. Returning a new array from the metadata instead of the reference for the existing array solves this issue
|
lgtm |
|
Thank you both for the fix. Is there any chance this could be backported to v10? |
|
I don’t see a reason not to, it’s a small fix. |
|
I'm also happy to put up that PR if need be! |
12 tasks
|
@kamilmysliwiec @roypeled I created a PR to backport this fix to v10. Please advise on how to proceed, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a field resolver with an input we reached a bad edge case where the fields array was fetched via reference instead of an immutable array. This caused artifacts appearing in the array and bad metadata appeared when trying to parse the schema.
Returning a new array from the metadata instead of the reference for the existing array solves this issue
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#2360 (comment)
Issue Number: 2360
What is the new behavior?
Fields resolver works correctly.
Does this PR introduce a breaking change?
Other information