Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ref type and type guards #1796

Closed
wants to merge 2 commits into from
Closed

Conversation

mr-kenikh
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1646

What is the new behavior?

Type Ref and type guards isDocument, isDocumentArray, isRefType, isRefTypeArray provide compatibility with TypeScript.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The ref property can be either ObjectId or Document.
Type Ref and type guards provide compatibility with TypeScript.

Resolves nestjs#1646
@mr-kenikh mr-kenikh changed the title Ref type feat: add Ref type and type guards May 15, 2023
@kamilmysliwiec
Copy link
Member

This looks like something that should be added to the mongoose library instead of @nestjs/mongoose, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants