Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assets copying from 'nest build' is problematic #1264

Merged
merged 1 commit into from Oct 18, 2021

Conversation

NikolaPeevski
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Currently the closeWatcher executes midway of copying assets. Very notisable in a file structure with a lot of subfolders/files.

Issue Number: #1117

What is the new behavior?

Refactored closeWatchers to check if a recent action has been exectued in order to reduce race conditions and reset the timer. Additional timeout will trigger repeating the process until a recent action has not been executed, at which it will close the watchers.

Note: The race condition could still be a problematic factor when copying bigger files, I'd assume, for which a more clever/robust solution should be applied. Additionally the timeout of 300 was increased to 500 to lessen the timeout spam on the event loop. Could be increased further upon analysing or set dynamically based on file sizes/files count ratio to reduce spam.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This was a pickle to investigate. Good find.

@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants