Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): rename Developement to Development #1350

Merged
merged 1 commit into from Sep 30, 2021
Merged

fix(doc): rename Developement to Development #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/package-managers/abstract.package-manager.ts
View file
Open in desktop
Expand Up @@ -102,7 +102,7 @@ export abstract class AbstractPackageManager {
return dependencies as ProjectDependency[];
}

public async getDevelopement(): Promise<ProjectDependency[]> {
public async getDevelopment(): Promise<ProjectDependency[]> {
const packageJsonContent = await this.readPackageJson();
const packageJsonDevDependencies: any = packageJsonContent.devDependencies;
const dependencies = [];
Expand Down Expand Up @@ -134,7 +134,7 @@ export abstract class AbstractPackageManager {
await this.update(commandArguments);
}

public async updateDevelopement(dependencies: string[]) {
public async updateDevelopment(dependencies: string[]) {
const commandArguments = `${this.cli.update} ${dependencies.join(' ')}`;
await this.update(commandArguments);
}
Expand All @@ -149,7 +149,7 @@ export abstract class AbstractPackageManager {
await this.addProduction(dependencies, tag);
}

public async upgradeDevelopement(dependencies: string[], tag: string) {
public async upgradeDevelopment(dependencies: string[], tag: string) {
await this.deleteDevelopment(dependencies);
await this.addDevelopment(dependencies, tag);
}
Expand Down
4 changes: 2 additions & 2 deletions test/lib/package-managers/npm.package-manager.spec.ts
View file
Open in desktop
Expand Up @@ -79,7 +79,7 @@ describe('NpmPackageManager', () => {
const spy = jest.spyOn((packageManager as any).runner, 'run');
const dependencies = ['@nestjs/common', '@nestjs/core'];
const command = `update ${dependencies.join(' ')}`;
packageManager.updateDevelopement(dependencies);
packageManager.updateDevelopment(dependencies);
expect(spy).toBeCalledWith(command, true);
});
});
Expand Down Expand Up @@ -113,7 +113,7 @@ describe('NpmPackageManager', () => {
.map((dependency) => `${dependency}@${tag}`)
.join(' ')}`;

return packageManager.upgradeDevelopement(dependencies, tag).then(() => {
return packageManager.upgradeDevelopment(dependencies, tag).then(() => {
expect(spy.mock.calls).toEqual([
[uninstallCommand, true],
[installCommand, true],
Expand Down
4 changes: 2 additions & 2 deletions test/lib/package-managers/pnpm.package-manager.spec.ts
View file
Open in desktop
Expand Up @@ -79,7 +79,7 @@ describe('NpmPackageManager', () => {
const spy = jest.spyOn((packageManager as any).runner, 'run');
const dependencies = ['@nestjs/common', '@nestjs/core'];
const command = `update ${dependencies.join(' ')}`;
packageManager.updateDevelopement(dependencies);
packageManager.updateDevelopment(dependencies);
expect(spy).toBeCalledWith(command, true);
});
});
Expand Down Expand Up @@ -113,7 +113,7 @@ describe('NpmPackageManager', () => {
.map((dependency) => `${dependency}@${tag}`)
.join(' ')}`;

return packageManager.upgradeDevelopement(dependencies, tag).then(() => {
return packageManager.upgradeDevelopment(dependencies, tag).then(() => {
expect(spy.mock.calls).toEqual([
[uninstallCommand, true],
[installCommand, true],
Expand Down
4 changes: 2 additions & 2 deletions test/lib/package-managers/yarn.package-manager.spec.ts
View file
Open in desktop
Expand Up @@ -79,7 +79,7 @@ describe('YarnPackageManager', () => {
const spy = jest.spyOn((packageManager as any).runner, 'run');
const dependencies = ['@nestjs/common', '@nestjs/core'];
const command = `upgrade ${dependencies.join(' ')}`;
packageManager.updateDevelopement(dependencies);
packageManager.updateDevelopment(dependencies);
expect(spy).toBeCalledWith(command, true);
});
});
Expand Down Expand Up @@ -113,7 +113,7 @@ describe('YarnPackageManager', () => {
.map((dependency) => `${dependency}@${tag}`)
.join(' ')}`;

return packageManager.upgradeDevelopement(dependencies, tag).then(() => {
return packageManager.upgradeDevelopment(dependencies, tag).then(() => {
expect(spy.mock.calls).toEqual([
[uninstallCommand, true],
[installCommand, true],
Expand Down