fix(core): prevents renaming global providers and modules

nestjs · Jun 2, 2022 · 4487924 · 4487924
1 parent 018fd6b
commit 4487924
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/packages/core/repl/repl-context.ts b/packages/core/repl/repl-context.ts
@@ -59,22 +59,25 @@ export class ReplContext {
   }
 
   private initializeContext() {
-    const globalRef = globalThis;
     const modules = this.container.getModules();
 
     modules.forEach(moduleRef => {
       let moduleName = moduleRef.metatype.name;
       if (moduleName === InternalCoreModule.name) {
         return;
       }
-      if (globalRef[moduleName]) {
+      if (globalThis[moduleName]) {
         moduleName += ` (${moduleRef.token})`;
       }
 
       this.introspectCollection(moduleRef, moduleName, 'providers');
       this.introspectCollection(moduleRef, moduleName, 'controllers');
 
-      globalRef[moduleName] = moduleRef.metatype;
+      // For in REPL auto-complete functionality
+      Object.defineProperty(globalThis, moduleName, {
+        value: moduleRef.metatype,
+        configurable: false,
+      });
     });
   }
 
@@ -93,7 +96,10 @@ export class ReplContext {
         return;
       }
       // For in REPL auto-complete functionality
-      globalThis[stringifiedToken] = token;
+      Object.defineProperty(globalThis, stringifiedToken, {
+        value: token,
+        configurable: false,
+      });
 
       if (stringifiedToken === ModuleRef.name) {
         return;