feat: move get pattern to top level method of switch to ws

nestjs · Nov 9, 2022 · 691049c · 691049c
1 parent 4bec058
commit 691049c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/integration/websockets/src/request.interceptor.ts b/integration/websockets/src/request.interceptor.ts
@@ -4,7 +4,7 @@ import { CallHandler, ExecutionContext, Injectable } from '@nestjs/common';
 export class RequestInterceptor {
   intercept(context: ExecutionContext, next: CallHandler) {
     const client = context.switchToWs().getClient();
-    const pattern = client.getPattern();
+    const pattern = context.switchToWs().getPattern();
     client.pattern = pattern;
     return next.handle();
   }

diff --git a/packages/common/interfaces/features/arguments-host.interface.ts b/packages/common/interfaces/features/arguments-host.interface.ts
@@ -31,6 +31,10 @@ export interface WsArgumentsHost {
    * Returns the client object.
    */
   getClient<T = any>(): T;
+  /**
+   * Returns the pattern for the event
+   */
+  getPattern(): string;
 }
 
 /**

diff --git a/packages/core/helpers/execution-context-host.ts b/packages/core/helpers/execution-context-host.ts
@@ -59,6 +59,7 @@ export class ExecutionContextHost implements ExecutionContext {
     return Object.assign(this, {
       getClient: () => this.getArgByIndex(0),
       getData: () => this.getArgByIndex(1),
+      getPattern: () => this.getArgByIndex(this.getArgs().length - 1),
     });
   }
 }
diff --git a/packages/websockets/context/ws-context-creator.ts b/packages/websockets/context/ws-context-creator.ts
@@ -108,9 +108,7 @@ export class WsContextCreator {
     };
 
     return this.wsProxy.create(async (...args: unknown[]) => {
-      Object.assign(args[0] ?? {}, {
-        getPattern: () => this.reflectCallbackPattern(callback),
-      });
+      args.push(this.reflectCallbackPattern(callback));
       const initialArgs = this.contextUtils.createNullArray(argsLength);
       fnCanActivate && (await fnCanActivate(args));