Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): pass options to rmq deserialize #10022

Merged

Conversation

bangbang93
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

RmqRecordDeserializer#deserialize always got an undefined as options, cannot pair of RmqRecordSerializer#serialize
Issue Number: N/A

What is the new behavior?

Pass Rmq Message properties as options, just like what serialize does

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Jul 26, 2022

Pull Request Test Coverage Report for Build a9588963-b7ac-4df2-89c5-07d8b60662bd

  • 6 of 7 (85.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 94.026%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/client/client-rmq.ts 5 6 83.33%
Totals Coverage Status
Change from base Build 8ef0dd2b-a478-4378-b9d0-9a314f70870c: 0.004%
Covered Lines: 6060
Relevant Lines: 6445

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit 7c40213 into nestjs:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants