fix(microservice): grpc-client serialize error #10110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10104
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #10104
What is the new behavior?
this.serializeError(error)
is called before returning an error inclient-grpc.ts
,this matches the behavior to the the rest of
ClientProxy
implementationsDoes this PR introduce a breaking change?
Other information
I didn't find any test cases for error handling, please refer me to any if i missed it.
Added a basic test to make sure old behavior is not affected when
serializeError
is not overridden