Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export cache module options token under easy name #10143

Merged

Conversation

jmcdo29
Copy link
Member

@jmcdo29 jmcdo29 commented Aug 18, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

In Nest v9 now that we use the ConfigurableModuleBuilder we no longer expose the CACHE_MODULE_OPTIONS token that we used to in v8

What is the new behavior?

Re-expose the CACHE_MODULE_OPTIONS as an alias for MODULE_OPTIONS_TOKEN so that the cache module options can be easily overwritten in a test rather than having to import { MODULE_OPTIONS_TOKEN } from '@nestjs/common/cache/cache.module-definitions'

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build c7cf292a-3107-4d30-9c1c-9ed62ef1e8d5

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.812%

Totals Coverage Status
Change from base Build ec438b34-a56e-4f82-ae11-45373f207a16: 0.0%
Covered Lines: 6094
Relevant Lines: 6496

💛 - Coveralls

Copy link
Member

@MarkPieszak MarkPieszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️♥️💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants