Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): getOptionsProp doesn't ignore a non-empty value #10448

Closed
wants to merge 1 commit into from

Conversation

IKatsuba
Copy link
Contributor

@IKatsuba IKatsuba commented Oct 24, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

ClientProxy.getOptionsProp returns undefined instead of non-empty value (0, an empty string, etc)

Issue Number: N/A

What is the new behavior?

ClientProxy.getOptionsProp returns a non-empty value (0, an empty string, etc)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0deb9659-9cfb-40d4-9cfc-17c5b7140669

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.788%

Totals Coverage Status
Change from base Build 8bf86286-b462-4455-92cd-c0e58fd6edb9: 0.0%
Covered Lines: 6115
Relevant Lines: 6520

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Let's track this here #10549 (more info here #10549 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants