Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): correct order for logger error parameters #10531

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix(common): correct order for logger error parameters #10531

merged 1 commit into from
Feb 1, 2023

Commits on Nov 7, 2022

  1. fix(common): correct order for logger error parameters 

    The error() function of a logger has two optional parameters: the trace and the context. The logger
now no longer passes the global context as the first optional parameter when there are is no value
supplied for the trace parameter. Instead, the trace parameter is passed as undefined and the
context is passed as the second optional parameter.

This fixes a bug where the trace is overwritten by the context when passed to custom loggers.
Fixes gremo/nest-winston#473
    @ChrisiPK
    ChrisiPK committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    584015b View commit details
    Browse the repository at this point in the history