feat(common)!: narrow getInstance return type for http adapters
#10630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micalevisk
force-pushed
the
feat/narrowing-http-adapter-instance-type
branch
from
a04a9ce
to
3440821
Compare
Pull Request Test Coverage Report for Build 20f5ce29-a2a2-48d9-8a72-11fe13dacc5d
💛 - Coveralls |
|
@kamilmysliwiec does this introduces a breaking change? I just notice that I have checked the wrong box lol |
|
Well actually I might be the one who flagged this PR as breaking 😄 Since it no longer returns |
micalevisk
changed the title
getInstance return type for http adaptersgetInstance return type for http adapters
micalevisk
force-pushed
the
feat/narrowing-http-adapter-instance-type
branch
2 times, most recently
from
23abc80
to
eaff999
Compare
micalevisk
force-pushed
the
feat/narrowing-http-adapter-instance-type
branch
from
eaff999
to
701f7e8
Compare
|
Could you resolve merge conflicts @micalevisk 🙏 ? |
micalevisk
force-pushed
the
feat/narrowing-http-adapter-instance-type
branch
from
701f7e8
to
3b6b66b
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The return type of
HttpServer#getInstanceis alwaysanyeven when we explicitly supply the adapter type (NestExpressApplication/NestFastifyApplication) toNestFactory.createWhat is the new behavior?
Depending on which HTTP adapter is being used, we have a type-strong return on
getInstance(). Now one don't need to find out what's that returned objectDoes this PR introduce a breaking change?