Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(express): Map missing multer error and map busboy errors #10880

Merged
merged 1 commit into from Feb 1, 2023

Conversation

max-mathieu
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Some malformed requests return as 500 instead of 400. This can be worked around by a custom exception filter, but it would be great for the MulterModule to handle this natively.

What is the new behavior?

multer errors, as well as some raw busboy/multipart errors now return as 400 instead of 500.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3bb3c021-79cd-47f8-bd4f-e8cd2a36e80e

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.412%

Totals Coverage Status
Change from base Build 43c8609d-7c9b-40c5-85e1-094c9c517952: 0.003%
Covered Lines: 6210
Relevant Lines: 6648

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

lgtm

@max-mathieu max-mathieu deleted the multer-errors branch February 3, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants