Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fastify): return the response on exception #10889

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix(fastify): return the response on exception #10889

merged 1 commit into from
Feb 1, 2023

Commits on Jan 16, 2023

  1. fix(fastify): return the response on exception 

    Fastify requires us to return the response object when handling async
methods and dealing with exceptions, otherwise a thenable gets wrapped
and improperly handled later causing an exception. This is shown by
[this repo][1] and discuessed in [this issue][2].

[1]: https://github.com/sgrigorev/nestjs-compress-issue
[2]: fastify/fastify-compress#215 (comment)
    @jmcdo29
    jmcdo29 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    1217bc1 View commit details
    Browse the repository at this point in the history