Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common)!: when transforming optional boolean parameters on ValidationPipe #10953

Merged
merged 2 commits into from Apr 5, 2023
Merged

fix(common)!: when transforming optional boolean parameters on ValidationPipe #10953

merged 2 commits into from Apr 5, 2023

Commits on Jan 26, 2023

  1. test(common): add tests for broken cases on ValidationPipe 

    when transforming booleans with non-valid boolean values
    @micalevisk
    micalevisk committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    bcf4bf9 View commit details
    Browse the repository at this point in the history

  2. fix(common): when transforming invalid boolean values 

    on `ValidationPipe`, it must not return a valid boolean
    @micalevisk
    micalevisk committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    14a0f06 View commit details
    Browse the repository at this point in the history