Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): import common package correctly #11027

Merged
merged 1 commit into from Feb 3, 2023

Conversation

meteorlxy
Copy link
Contributor

@meteorlxy meteorlxy commented Feb 3, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Using relative path import will fail in pnpm workspace

Error: Cannot find module '../../common/utils/random-string-generator.util'
Require stack:
- /path/to/project/node_modules/.pnpm/@nestjs+core@9.3.1/node_modules/@nestjs/core/inspector/uuid-factory.js
- /path/to/project/node_modules/.pnpm/@nestjs+core@9.3.1/node_modules/@nestjs/core/injector/instance-wrapper.js

What is the new behavior?

No errors

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build 002b15b1-f421-4561-8ede-4c7fd4ed6e9d

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.939%

Totals Coverage Status
Change from base Build 6032d3ea-d47b-430d-a0be-73d44b81f028: 0.0%
Covered Lines: 6384
Relevant Lines: 6869

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit dac07fa into nestjs:master Feb 3, 2023
@meteorlxy meteorlxy deleted the fix/import-common branch February 3, 2023 09:32
@meteorlxy
Copy link
Contributor Author

It's kind of a critical issue. Hope we could have a patch release asap.

@kamilmysliwiec
Copy link
Member

I'll publish a new release very shortly (today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants