Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): when postfixId is an empty string on kafka #11540

Closed
wants to merge 9 commits into from

Conversation

Auspicus
Copy link

@Auspicus Auspicus commented Apr 21, 2023

getOptionsProp does an || with the passed value so empty strings end up being set as undefined

We may want to add a test for this since it doesn't seem like this behavior was covered.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Passing postfixId: '' does not do what you'd expect and instead continues to the use the default postfixId values

What is the new behavior?

Passing postfixId: '' will now correctly unset the postfixId and disable that behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Current behavior is a bug but users might be relying on the bug.

Other information

@coveralls
Copy link

coveralls commented Apr 21, 2023

Pull Request Test Coverage Report for Build 6c2e47bb-fd86-4b30-922b-f0dbb7761765

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 92.679%

Totals Coverage Status
Change from base Build 4d97af2b-5b7e-488e-a334-ead2f9bfc8a8: 0.004%
Covered Lines: 6520
Relevant Lines: 7035

💛 - Coveralls

@Auspicus
Copy link
Author

Fixed by: #10549

@Auspicus Auspicus closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants