Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): global prefix exclude when versioning is turned on #11650

Merged
merged 1 commit into from May 24, 2023

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented May 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: Closes #10215 & #11442

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6c3d4659-1727-453f-ad5b-1a387edd7629

  • 2 of 10 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.829%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/router/route-path-factory.ts 2 10 20.0%
Totals Coverage Status
Change from base Build ef2f21dd-cec1-46f3-aa9b-c798b1eab04c: -0.1%
Covered Lines: 6291
Relevant Lines: 6777

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec added this to the 10.0.0 milestone May 23, 2023
@kamilmysliwiec kamilmysliwiec merged commit b1be7a3 into 10.0.0 May 24, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/global-prefix-exclude-with-versioning branch May 24, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants