feat(express): add support for multer.none #11667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewtrivett
force-pushed
the
support-multer-none
branch
from
661af53
to
009affa
Compare
Pull Request Test Coverage Report for Build 90f15255-9556-4330-a372-5f345920a7ae
💛 - Coveralls |
Adds an interceptor for multer's none option https://github.com/expressjs/multer#none. This allows for Nest.js users to process `multipart/form-data` that does not include any files.
mathewtrivett
force-pushed
the
support-multer-none
branch
from
009affa
to
e2c15af
Compare
mehmetik
approved these changes
May 30, 2023
10 tasks
|
@kamilmysliwiec apologies to @ you but I couldn't see another way to request a review by maintainers. Do you have any thoughts on this PR and the associated docs PR? Appreciate your time. |
rubiin
approved these changes
Jun 2, 2023
|
lgtm |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an interceptor for multer's none option https://github.com/expressjs/multer#none. This allows for Nest.js users to process
multipart/form-datathat does not include any files.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
I am implementing a feature that uses the Sendgrid Inbound Parse API. This sends the data encoded as
multipart/form-datahowever the payload includes no files. I believe all data are sent as strings/text.I reached for the Nest.js MulterModule but it currently does not support multer's none option.
multer.noneparses only the text fields in the body and raises an exception if any files are submitted.What is the new behavior?
This PR adds a new NoFilesInterceptor and associated tests. This would allow MulterModule users to accept
multipart/form-datawithout any files.Does this PR introduce a breaking change?
Other information
There is a separate but related PR in the docs project nestjs/docs.nestjs.com#2747.
Also, if there is a way to natively handle text only
multipart/form-datawithout the MulterModule would be great to know about that.