Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): apply middleware to versioned controllers (ctrl-level) #11785

Merged
merged 1 commit into from Jun 14, 2023

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build dc855507-0dbf-4e6f-87b1-1f81e54d1092

  • 30 of 30 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.799%

Totals Coverage Status
Change from base Build 8693c071-2932-4dd8-8f1d-6a4f6df3c423: 0.02%
Covered Lines: 6340
Relevant Lines: 6832

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit c01ea3f into master Jun 14, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/middleware-for-versioned-ctrls branch June 14, 2023 10:09
@mareksuscak
Copy link

mareksuscak commented Jun 22, 2023

I feel like this change has broken some of our middleware and we had to update the regexes. May not be exactly this one but something in v10 introduced yet another breaking change. The middleware path matching has been super unstable over the past few releases. Here's the relevant changeset and the highlighted line is what no longer worked for us and we had to use :splat* instead of (.*) for some reason.

CleanShot 2023-06-22 at 18 01 01

@frankdavidcorona
Copy link

Hi contributors,

Currently, I'm facing this issue in my application, I'm currently running with these packages versions:

"@nestjs/common": "9.4.3",
"@nestjs/core": "9.4.3",

The solution has been published to any latest version of NestJS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants