Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(microservices): fix usage noassert flag in rabbitmq #13313

Closed
wants to merge 1 commit into from

Conversation

mcflypl
Copy link

@mcflypl mcflypl commented Mar 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

When using the ClientRMQ module with the noAssert flag set to true, the assertQueue method still gets invoked.

What is the new behavior?

After setting the noAssert flag to true, the assertQueue method is not triggered.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build db08bec1-748c-4d42-b761-571766d872f7

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.16%

Totals Coverage Status
Change from base Build eb21d71b-6f53-4104-9eb0-8af163c8aa17: 0.0%
Covered Lines: 6736
Relevant Lines: 7309

💛 - Coveralls

Copy link
Contributor

@dammy001 dammy001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dammy001
Copy link
Contributor

@mcflypl This looks like duplicate of #13285

@kamilmysliwiec
Copy link
Member

Let's track this here #13285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants