Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ws): optimize message handler lookup #13378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(ws): optimize message handler lookup #13378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/platform-ws/adapters/ws-adapter.ts
View file
Open in desktop
Expand Up @@ -111,10 +111,13 @@ export class WsAdapter extends AbstractWsAdapter {
handlers: MessageMappingProperties[],
transform: (data: any) => Observable<any>,
) {
const handlersMap = new Map<string, MessageMappingProperties>();
handlers.forEach(handler => handlersMap.set(handler.message, handler));

const close$ = fromEvent(client, CLOSE_EVENT).pipe(share(), first());
const source$ = fromEvent(client, 'message').pipe(
mergeMap(data =>
this.bindMessageHandler(data, handlers, transform).pipe(
this.bindMessageHandler(data, handlersMap, transform).pipe(
filter(result => !isNil(result)),
),
),
Expand All @@ -131,14 +134,12 @@ export class WsAdapter extends AbstractWsAdapter {

public bindMessageHandler(
buffer: any,
handlers: MessageMappingProperties[],
handlersMap: Map<string, MessageMappingProperties>,
transform: (data: any) => Observable<any>,
): Observable<any> {
try {
const message = JSON.parse(buffer.data);
const messageHandler = handlers.find(
handler => handler.message === message.event,
);
const messageHandler = handlersMap.get(message.event);
const { callback } = messageHandler;
return transform(callback(message.data, message.event));
} catch {
Expand Down