Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(microservices): improve speed of grpc server initialization #13392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(microservices): improve speed of grpc server initialization #13392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/microservices/server/server-grpc.ts
View file
Open in desktop
Expand Up @@ -560,14 +560,19 @@ export class ServerGrpc extends Server implements CustomTransportStrategy {
? deepDefinition.service !== false
: false;

// grpc namespace object does not have 'format' or 'service' properties defined
const isFormatDefined =
deepDefinition && !isUndefined(deepDefinition.format);

if (isServiceDefined && isServiceBoolean) {
accumulator.push({
name: nameExtended,
service: deepDefinition,
});
}
// Continue recursion until objects end or service definition found
else {
} else if (isFormatDefined) {
// Do nothing
} else {
// Continue recursion for namespace object until objects end or service definition found
this.collectDeepServices(nameExtended, deepDefinition, accumulator);
}
}
Expand Down