Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add public api annotation on microservices #13537

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented May 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Proposal:

  • Added public api annotation (@publicApi) on microservices, in the following files:
    - packages/microservices/ctx-host/base-rpc.context.ts
    - packages/microservices/ctx-host/kafka.context.ts
    - packages/microservices/ctx-host/mqtt.context.ts
    - packages/microservices/ctx-host/nats.context.ts
    - packages/microservices/ctx-host/redis.context.ts
    - packages/microservices/ctx-host/rmq.context.ts
    - packages/microservices/ctx-host/tcp.context.ts
    - packages/microservices/record-builders/mqtt.record-builder.ts
    - packages/microservices/record-builders/nats.record-builder.ts
    - packages/microservices/record-builders/rmq.record-builder.ts
    - packages/microservices/server/server-grpc.ts
    - packages/microservices/server/server-kafka.ts
    - packages/microservices/server/server-mqtt.ts
    - packages/microservices/server/server-nats.ts
    - packages/microservices/server/server-redis.ts
    - packages/microservices/server/server-rmq.ts
    - packages/microservices/server/server-tcp.ts
    - packages/microservices/server/server.ts

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build fbf2ca6f-2312-4e67-a66b-a9099df1954c

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.124%

Totals Coverage Status
Change from base Build e56f6d99-d9bc-426a-b9ef-ed11406d7e1c: 0.0%
Covered Lines: 6737
Relevant Lines: 7313

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit c750ec1 into nestjs:master May 8, 2024
5 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants