Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix applying falsy options from config #3119

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Conversation

egmen
Copy link

@egmen egmen commented Oct 7, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3800

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.194%

Totals Coverage Status
Change from base Build 3710: 0.0%
Covered Lines: 4358
Relevant Lines: 4578

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Thank you! Can you do the same fix for client classes (client-proxy etc)?

@egmen
Copy link
Author

egmen commented Oct 16, 2019

@kamilmysliwiec i'll wait nullish coalescing in TS 3.7 microsoft/TypeScript#26578 to fix this issue.
Ok?

@kamilmysliwiec
Copy link
Member

kamilmysliwiec commented Oct 26, 2019

Perhaps we should move forward with this issue now. We can always refactor after the update cc @egmen

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.9.0 October 31, 2019 12:36
@kamilmysliwiec kamilmysliwiec added this to the 6.9.0 milestone Oct 31, 2019
@kamilmysliwiec kamilmysliwiec merged commit e8fdb57 into nestjs:6.9.0 Oct 31, 2019
@lock
Copy link

lock bot commented Jan 30, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants