Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add missing optional dependencies #5477

Merged
merged 1 commit into from Dec 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/common/package.json
Expand Up @@ -25,6 +25,20 @@
},
"peerDependencies": {
"reflect-metadata": "^0.1.12",
"rxjs": "^6.0.0"
"rxjs": "^6.0.0",
"cache-manager": "*",
"class-validator": "*",
"class-transformer": "*"
},
"peerDependenciesMeta": {
"cache-manager": {
"optional": true
},
"class-validator": {
"optional": true
},
"class-transformer": {
"optional": true
}
}
}
14 changes: 14 additions & 0 deletions packages/core/package.json
Expand Up @@ -39,8 +39,22 @@
"@nestjs/common": "7.4.4"
},
"peerDependencies": {
"@nestjs/websockets": "^7.0.0",
"@nestjs/microservices": "^7.0.0",
"@nestjs/platform-express": "^7.0.0",
"@nestjs/common": "^7.0.0",
"reflect-metadata": "^0.1.12",
"rxjs": "^6.0.0"
},
"peerDependenciesMeta": {
"@nestjs/websockets": {
"optional": true
},
"@nestjs/microservices": {
"optional": true
},
"@nestjs/platform-express": {
"optional": true
}
}
}
41 changes: 40 additions & 1 deletion packages/microservices/package.json
Expand Up @@ -26,8 +26,47 @@
"@nestjs/core": "7.4.4"
},
"peerDependencies": {
"reflect-metadata": "^0.1.12",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not optional, see:

import 'reflect-metadata';

"@nestjs/common": "^7.0.0",
"@nestjs/core": "^7.0.0",
"rxjs": "^6.0.0"
"@nestjs/websockets": "^7.0.0",
"rxjs": "^6.0.0",
"cache-manager": "*",
"grpc": "*",
"kafkajs": "*",
"mqtt": "*",
"nats": "*",
"redis": "*",
"amqplib": "*",
"amqp-connection-manager": "*"
},
"peerDependenciesMeta": {
"@nestjs/websockets": {
"optional": true
},
"cache-manager": {
"optional": true
},
"grpc": {
"optional": true
},
"kafkajs": {
"optional": true
},
"mqtt": {
"optional": true
},
"nats": {
"optional": true
},
"redis": {
"optional": true
},
"amqplib": {
"optional": true
},
"amqp-connection-manager": {
"optional": true
}
}
}
12 changes: 11 additions & 1 deletion packages/testing/package.json
Expand Up @@ -22,6 +22,16 @@
},
"peerDependencies": {
"@nestjs/common": "^7.0.0",
"@nestjs/core": "^7.0.0"
"@nestjs/core": "^7.0.0",
"@nestjs/microservices": "^7.0.0",
"@nestjs/platform-express": "^7.0.0"
},
"peerDependenciesMeta": {
"@nestjs/microservices":{
"optional": true
},
"@nestjs/platform-express":{
"optional": true
}
}
}
3 changes: 2 additions & 1 deletion packages/websockets/package.json
Expand Up @@ -22,6 +22,7 @@
"peerDependencies": {
"@nestjs/common": "^7.0.0",
"@nestjs/core": "^7.0.0",
"rxjs": "^6.0.0"
"rxjs": "^6.0.0",
"reflect-metadata": "^0.1.12"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually not optional, see:

import 'reflect-metadata';

}
}