Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): migrate redis transporter to internally use ioredis package #8798

Merged
merged 5 commits into from May 17, 2022

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Dec 16, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Redis transporter uses ioredis instead of redis package and that means there will be some configuration-related breaking changes

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 66be4e79-4c3a-417c-8117-4e12d59653e4

  • 20 of 24 (83.33%) changed or added relevant lines in 3 files are covered.
  • 27 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.01%) to 94.085%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/server/server-redis.ts 9 10 90.0%
packages/microservices/client/client-redis.ts 9 12 75.0%
Files with Coverage Reduction New Missed Lines %
packages/common/utils/is-uuid.ts 1 83.33%
packages/core/injector/module-token-factory.ts 1 94.29%
packages/core/router/sse-stream.ts 1 92.59%
packages/microservices/client/client-redis.ts 1 89.47%
packages/common/file-stream/streamable-file.ts 2 76.19%
packages/microservices/server/server-mqtt.ts 2 84.5%
packages/microservices/client/client-nats.ts 5 87.41%
packages/core/scanner.ts 14 89.45%
Totals Coverage Status
Change from base Build 345bca26-5199-46ca-9736-f28b090b78f2: -0.01%
Covered Lines: 5647
Relevant Lines: 6002

💛 - Coveralls

@luin
Copy link

luin commented Mar 28, 2022

Hey @kamilmysliwiec 👋 ,

I'm the author of ioredis. We just released ioredis v5.0.0 which provides official TypeScript declarations so @types/ioredis is not necessary anymore.

Also, feel free to lmk if there is anything we can do on the ioredis side to avoid/reduce the configuration-related breaking changes.

@kamilmysliwiec
Copy link
Member Author

Thanks for letting me know @luin, appreciate that! 🙌

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 9.0.0 May 17, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants