New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only send exception responses if header is not already sent #8802
Merged
kamilmysliwiec
merged 11 commits into
nestjs:9.0.0
from
wSedlacek:fix/interceptor-check-headers-sent
Jun 20, 2022
Merged
fix: only send exception responses if header is not already sent #8802
kamilmysliwiec
merged 11 commits into
nestjs:9.0.0
from
wSedlacek:fix/interceptor-check-headers-sent
Jun 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Pull Request Test Coverage Report for Build 76e79d94-3655-4331-aa6d-cef51bdcc711
💛 - Coveralls |
micalevisk
reviewed
Dec 17, 2021
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
micalevisk
reviewed
May 21, 2022
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
When an exception is thrown it will trigger the exception filter to try to send a reply.
If a header was already sent then the exception filter will fail to send this reply.
Does this PR introduce a breaking change?
This change requires adapters to provide two new methods,
isHeaderSent()
andend()
Other information