Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add configurable module builder, module utils #9534

Merged
merged 5 commits into from May 17, 2022
Merged

feat(core): add configurable module builder, module utils #9534

merged 5 commits into from May 17, 2022

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

jmcdo29
jmcdo29 approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew this is some cool stuff! Excited to see it make it to release and replace some of the existing dynamic modules we have. Can't wait to update some of our other packages with this

@coveralls
Copy link

Pull Request Test Coverage Report for Build 292f84ed-fecc-4740-98e4-2253ddc37ba2

  • 68 of 73 (93.15%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 94.107%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/common/module-utils/configurable-module.builder.ts 54 59 91.53%
Files with Coverage Reduction New Missed Lines %
packages/microservices/client/client-rmq.ts 6 84.87%
Totals Coverage Status
Change from base Build 8b72e133-19cf-4b7b-92ad-2f270d8b056e: 0.06%
Covered Lines: 5829
Relevant Lines: 6194
💛 - Coveralls

Tony133
Tony133 approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@Tony133 Tony133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wait to try this very cool new feature! 😻

@kamilmysliwiec kamilmysliwiec added this to the 9.0.0 milestone May 13, 2022
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 9.0.0 May 17, 2022 11:14
@kamilmysliwiec kamilmysliwiec merged commit fc95619 into 9.0.0 May 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat/module-utils branch May 17, 2022 11:14
This was referenced May 17, 2022
Closed
Merged
@kamilmysliwiec kamilmysliwiec mentioned this pull request Jun 14, 2022
Closed
@origranot
Copy link

So excited about it 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tony133 Tony133 Tony133 approved these changes

@micalevisk micalevisk micalevisk approved these changes

@jmcdo29 jmcdo29 jmcdo29 approved these changes

Assignees
No one assigned
Labels
scope: core type: feature 🎉
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kamilmysliwiec @coveralls @origranot @Tony133 @micalevisk @jmcdo29