Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(microservices): add kafka retriable exception, auto-unwrap payloads #9586

Merged
merged 12 commits into from May 17, 2022
Merged

feat(microservices): add kafka retriable exception, auto-unwrap payloads #9586

merged 12 commits into from May 17, 2022

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented May 17, 2022 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

More details: #9293

What is the new behavior?

Also fixes #5974 & #6254

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

davidschuette and others added 9 commits March 4, 2022 01:17
@davidschuette
feat(microservices): add commit offset to kafka context
5b24f81 
Provide access to kafkajs commitOffset by using @ctx() decorator when handeling an event.

This commit closes Kafka commitOffsets #9283.
@davidschuette
feat(microservices): dont catch errors thrown by kafka event handling
77b7bd6 
Error thrown by event handling method are no longer being caught by RcpExecptionFilter.
Instead errors are passed to kafkajs's eachMessage.
This results in proper interaction with kafka.

This commit closes Kafka commitOffsets #9283.
@davidschuette
fix(microservices): fix import path
c229a75
@davidschuette
feat(microservices): add consumer getter to kafka context
b91803c 
Provide access to native consumer of kafkajs using @ctx() decorator.
@davidschuette
refactor(microservices): simplify function call
0b93404
@davidschuette
test(microservices): add tests for kafka-rpc-proxy
37d83ee
@kamilmysliwiec
feat(microservices): add kafka retriable exception, rethrow if needed
a439055
@kamilmysliwiec
feat(microservices): add kafka request deserializer, unwrap request
6547f92
@kamilmysliwiec
feat(microservices): dont swallow kafka event handler exceptions
90af959
@coveralls
Copy link

coveralls commented May 17, 2022 •
edited

Pull Request Test Coverage Report for Build 1f7e7cca-82dd-4504-95eb-3b9dadde6b13

  • 31 of 37 (83.78%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 94.046%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/deserializers/kafka-request.deserializer.ts 4 5 80.0%
packages/microservices/server/server-kafka.ts 22 27 81.48%
Totals Coverage Status
Change from base Build a8c21889-cd98-4fa6-b9d1-d8880df268cc: -0.07%
Covered Lines: 5797
Relevant Lines: 6164
💛 - Coveralls

@kamilmysliwiec kamilmysliwiec added this to the 9.0.0 milestone May 17, 2022
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 9.0.0 May 17, 2022 11:19
@kamilmysliwiec kamilmysliwiec merged commit 66da12a into 9.0.0 May 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/propagate-kafka-errors branch May 17, 2022 11:21
This was referenced May 17, 2022
Closed
Merged
@kamilmysliwiec kamilmysliwiec mentioned this pull request May 30, 2022
Closed
15 tasks
@kamilmysliwiec kamilmysliwiec mentioned this pull request Jun 14, 2022
Closed
@tooleks tooleks mentioned this pull request Nov 30, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: microservices type: enhancement 🐺
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Kafka Microservice Does not validate DTO
3 participants
@kamilmysliwiec @coveralls @davidschuette