Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common,core,microservices): drop all deprecated methods #9604

Merged
merged 2 commits into from May 18, 2022

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

there are few functions marked with @deprecated

What is the new behavior?

all the deprecated functions no longer exists

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4b09d771-4607-4211-be00-7557b3ca3b1a

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 94.015%

Totals Coverage Status
Change from base Build f8f1559e-54b7-42d7-acf5-330f0a0be505: -0.001%
Covered Lines: 5812
Relevant Lines: 6182

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

LGTM!

@kamilmysliwiec kamilmysliwiec added this to the 9.0.0 milestone May 18, 2022
@micalevisk micalevisk deleted the drop-deprecated-functions branch May 18, 2022 14:52
@kamilmysliwiec kamilmysliwiec mentioned this pull request May 20, 2022
12 tasks
@micalevisk micalevisk changed the title refactor(common,core,microservices)!: drop all deprecated methods refactor(common,core,microservices): drop all deprecated methods May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants