-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core,common): add help messages to REPL built-in functions #9695
feat(core,common): add help messages to REPL built-in functions #9695
Conversation
I didn't change the test suite because I don't know if this proposal we be taken 😃 |
Great work @micalevisk! Feel free to update tests, I'd love to merge this in :) |
d126cd7
to
fbc0ab8
Compare
idk how to fix those failing assertions |
As for the unit tests that are failing, I suppose there's a tabs/spaces/new lines mismatch between expected vs actual. |
yeah, I didn't notice those trailing spaces. Also, I've moved the nested function under |
8d8130e
to
21030d9
Compare
Pull Request Test Coverage Report for Build c33f096f-7875-4e22-ba67-59ad23501b92
💛 - Coveralls |
21030d9
to
8f772c2
Compare
8f772c2
to
59965cf
Compare
5b56a27
to
fdefb1d
Compare
727cec7
to
0ceda2f
Compare
0ceda2f
to
833d16e
Compare
Fantastic contribution @micalevisk! 🙌 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
same as PR #9692 but with other interface regarding REPL built-in functions
demo.mp4
What is the differences between them?
ReplContext
is much cleaner. It doesn't have to deal with those built-in functionsextends ReplFunction
, and then we could pass a list of those class references to the mainrepl
function (if we implement such feature in the feature). As of now, they will live along the native ones (help
,debug
, etc)for instance, the
get
native function looks like this:pros
ReplContext
got easier to maintaincons
Does this PR introduce a breaking change?