Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): exposes base context on the main package #9719

Merged

Conversation

delucca
Copy link
Contributor

@delucca delucca commented Jun 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Exposes interface

What is the current behavior?

The BaseRpcContext class was not being exposed in the main package

What is the new behavior?

Now, the class is being exposed.

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build b61ea5fb-8354-4064-b4df-97d9a25958c0

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 94.108%

Totals Coverage Status
Change from base Build 3a79ae39-22dd-4c90-92e4-77db246e2790: 0.001%
Covered Lines: 5782
Relevant Lines: 6144

💛 - Coveralls

@delucca
Copy link
Contributor Author

delucca commented Jun 6, 2022

@kamilmysliwiec thanks! :)

I can't merge the PR (since it is only allowed to authorized users). So I'll wait for someone to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants