Improve stripProtoKeys performance, especially for TypedArray #9742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgp2
force-pushed
the
stripProtoKeys-performance
branch
2 times, most recently
from
fcd6fc1
to
2cca33a
Compare
1 task
mjgp2
force-pushed
the
stripProtoKeys-performance
branch
3 times, most recently
from
b2ea591
to
62d2f6d
Compare
Pull Request Test Coverage Report for Build 29996fd0-df63-435a-96f3-db353cf09d52
💛 - Coveralls |
micalevisk
suggested changes
Jun 9, 2022
micalevisk
reviewed
Jun 9, 2022
| @@ -190,12 +191,20 @@ export class ValidationPipe implements PipeTransform<any> { | |||
| return isNil(value) ? {} : value; | |||
| } | |||
|
|
|||
| protected stripProtoKeys(value: Record<string, any>) { | |||
| protected stripProtoKeys(value: any) { | |||
| if (value == null || typeof value !== 'object' || types.isTypedArray(value)) { | |||
There was a problem hiding this comment.
I guess
Suggested change
| if (value == null || typeof value !== 'object' || types.isTypedArray(value)) { | |
| if (!value || !isObject(value) || types.isTypedArray(value)) { |
There was a problem hiding this comment.
This causes a typescript compilation error because isObject is a type guard and Property '__proto__' does not exist on type 'object'
I would suggest just leaving as-is?
There was a problem hiding this comment.
Great, I think this should be good to merge then 🤞
mjgp2
force-pushed
the
stripProtoKeys-performance
branch
from
62d2f6d
to
f445f23
Compare
micalevisk
approved these changes
Jun 10, 2022
|
LGTM |
|
Thanks all, appreciate your work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 9708
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 9708
What is the new behavior?
Does not waste cycles on iterating through typed arrays, or allocating keys arrays.
Does this PR introduce a breaking change?
Other information