refactor(core): replace our own 1-level flatten by the native one #9902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
node12 has
Array.prototype.flat
method. See https://node.green/#ES2019-features-Array-prototype--flat--flatMap--Array-prototype-flatthus we don't need to write this logic anymore.
I didn't changed the
flatten
on@nestjs/common
because it is being used by other nestjs packages that didn't bumped their major version (ie., they still supports node10, I guess)nest/packages/common/decorators/core/dependencies.decorator.ts
Lines 3 to 8 in 34cb600
the above could be written like this:
arr.flat(Infinity)
Also, I've looked at every JS feature that was added in node12 (taking this table https://node.green) to see if there is something that we could update in this repo. Didn't find other feature tho.
Does this PR introduce a breaking change?