Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Fix CacheModule registerAsync #9904

Merged
merged 2 commits into from Jul 11, 2022
Merged

fix(common): Fix CacheModule registerAsync #9904

merged 2 commits into from Jul 11, 2022

Conversation

tugascript
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

It is not checking if there are extraProviders (an optional field), leading to a circular dependency error when you try to concat them.

Issue Number: #9903

What is the new behavior?

Adds a ternary operator to check if extraProviders exists.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Tested with podman-compose and not docker-compose, but it should not make a major difference.

@micalevisk
Copy link
Member

I guess we don't need those changes made on package-lock.json

tip: use npm ci instead of npm install so it won't touch the lock file

@micalevisk
Copy link
Member

micalevisk commented Jul 10, 2022

closes #9895

@coveralls
Copy link

Pull Request Test Coverage Report for Build 82de4ff8-2109-43ba-aeff-7c1fe6c800b4

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.91%

Totals Coverage Status
Change from base Build 89137624-bda6-49c5-bbc7-d5e6f900f6cc: 0.0%
Covered Lines: 6029
Relevant Lines: 6420

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit b449b5a into nestjs:master Jul 11, 2022
@kamilmysliwiec
Copy link
Member

LGTM

@tugascript tugascript deleted the fix-cache-module-async-register branch July 11, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants