Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): add Kafka heartbeat callback to KafkaContext #9954

Conversation

kosh-b
Copy link
Contributor

@kosh-b kosh-b commented Jul 19, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Implements #9949

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

#9949

Issue Number: 9949

What is the new behavior?

Adds heartbeat callback to KafkaContext (so it will be passed to the endpoint)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 302ab445-3d0a-4682-b9f8-8636af34c82e

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0009%) to 94.09%

Totals Coverage Status
Change from base Build 9b0871a2-2869-48ee-9715-bc995a860ea4: 0.0009%
Covered Lines: 6050
Relevant Lines: 6430

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

kamilmysliwiec commented Jul 19, 2022

Thanks for your contribution!

Looks good to me. Would you like to create a PR to the docs (adding one little section showcasing the heartbeat fn usage)?

@kosh-b
Copy link
Contributor Author

kosh-b commented Jul 19, 2022

Thanks!

I've created a pr for the documentation of the KafkaContext.heartbeat:
nestjs/docs.nestjs.com#2409

I'm not native english speaker, so feel free to adjust if needed :)

Also, if you have any adjustments for this pr (in case I've missed something related to nestjs internals), please share :)

@kamilmysliwiec
Copy link
Member

Thank you, @kosh-b! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants