Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use the configurable module class with passport module #1011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

floross
Copy link

@floross floross commented Aug 30, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

Nestjs 9 come with ConfigurableModuleOptions helpers. This PR tends to use this new class to clean the declaration of the passport module.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

This PR changes the interface using internally and externally to configure the options to clean the old interfaces

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant